Change postBuildExtras to use cordova provided list #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem where multiple cordova plugins attempting to use the postBuildExtras in the gradle script will simply clobber each other. The cordova provided gradle template provides a defined list for plugins to add their post build extras to so they can all play nicely together. https://github.com/apache/cordova-android/blob/73edf4de7b751ecc103e9fad3c6d71c149c9118e/bin/templates/project/app/build.gradle#L90 This fixes the problems outlined in: meteor/meteor#7600 Meteor-Community-Packages/raix-push#334
|
any progress here? |
|
It seems a similar change has been made in the original repository, is this equivalent to the fix proposed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where multiple cordova plugins attempting to use the postBuildExtras in the gradle script will simply clobber each other. The cordova provided gradle template provides a defined list for plugins to add their post build extras to so they can all play nicely together.
https://github.com/apache/cordova-android/blob/73edf4de7b751ecc103e9fad3c6d71c149c9118e/bin/templates/project/app/build.gradle#L90
This fixes the problems outlined in:
meteor/meteor#7600
Meteor-Community-Packages/raix-push#334