-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cordova Android, having a ext.postBuildExtras in a plugin gradle does not output cdvassets.manifest #7600
Comments
You'll have to forgive my unfamiliarity with the problem you're referring to and how it applies to Meteor. To my knowledge, Meteor doesn't support overriding I would highly recommend asking this question in the Meteor Forums where you might find more people that are familiar with the problem you're having. Meteor Issues are primarily a place to document bugs with the Meteor framework. As of right now, I'm not entirely sure this is a bug or if this is behaving as intended. |
I will do more a few more test next days. I have not this issue anymore since I cleaned up my code. But I suspect another one about not being able to recompile the assets on change. So we can close this for now, I will reopen if needed. |
I'm having the same problem, but in my case that section is empty:
I'm on the latest meteor: 1.4.2 |
I have had the same symptoms when updating a plugin so that it includes an I also found no |
@abernix, here's a super simple reproduction of the problem, created from @dagatsoin's detailed description: https://github.com/BudgieInWA/meteor-cordova-postBuildExtras-bug My current workaround is to run meteor to trigger a build, comment out the |
See #9590 - this is still happening with Meteor 1.6.x, so re-opening here. |
We faced the same problem on |
@martijnwalraven @hwillson Could you please look into this. Currently, no cordova plugins can be used that declare Suggestion of @menelike is no option, cause this will override the build-extras.gradle, disabling all extra configuration declared by other cordova plugins. This results in cordova packages like Thanks for looking into this! |
You are correct, just using https://github.com/meteor/cordova-plugin-meteor-webapp/blob/eb197016813475615ebc353298f40b8a4aa2629c/src/android/build-extras.gradle like mentioned above will of course not work together with If you need to get things working, the proper solution to include
This is of course just a workaround. |
@menelike thanks for your response. As long as there is no decent solution, we'll have to stick to workarounds like these. |
as the 1.7 is not far away, should it possible to put some ressource on this issue ? @abernix Have you got enough informations? |
This fixes the problem where multiple cordova plugins attempting to use the postBuildExtras in the gradle script will simply clobber each other. The cordova provided gradle template provides a defined list for plugins to add their post build extras to so they can all play nicely together. https://github.com/apache/cordova-android/blob/73edf4de7b751ecc103e9fad3c6d71c149c9118e/bin/templates/project/app/build.gradle#L90 This fixes the problems outlined in: meteor/meteor#7600 Meteor-Community-Packages/raix-push#334
My meteor version : 1.8
This configuration worked for me. I am using this in our production no crashes in last 3 days. :) |
Just testing
instead. Reading chemerisuk/cordova-support-google-services#17 (comment) this should still result in an error. Anyway, when I remove the workaround #7600 (comment) I can build the project and it runs in the emulator (did not test push notifications yet) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed it has not had recent activity. |
Meteor 1.3.5
When building for Android, having a ext.postBuildExtras in a plugin gradle file does not output cdvassets.manifest.
1- create an app and add android platform
2- now add a plugin with a post build extra gradle script
4- meteor build android --server http://localhost:3000
5- open the generated project, wait for gradle to build
When gradle finishes the build, you won't see assets/cdvassets.manifest
If you run it this will crash.
That makes #7046 or
As a work around I inversed my gradle plugin and the meteor cordova generated gradle:
But it totally breaks the workflow as, during dev, I have to:
And a bonus question: is there a particular reason to compile for 1.6 over 1.7?
The text was updated successfully, but these errors were encountered: