Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add list options API #1135

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close kcl-lang/kcl-go#254

feat: add list options API

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/src/service/capi.rs
  • kclvm/api/src/service/jsonrpc.rs
  • kclvm/api/src/service/service_impl.rs
  • kclvm/loader/src/option.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/api/src/testdata/option/main.k
  • kclvm/loader/src/snapshots/kclvm_loader__tests__builtin_call_0.snap
  • kclvm/loader/src/snapshots/kclvm_loader__tests__builtin_call_1.snap
  • kclvm/loader/src/snapshots/kclvm_loader__tests__builtin_call_2.snap
  • kclvm/loader/src/snapshots/kclvm_loader__tests__list_options_0.snap
  • kclvm/loader/src/snapshots/kclvm_loader__tests__list_options_1.snap
  • kclvm/loader/src/snapshots/kclvm_loader__tests__list_options_2.snap
  • kclvm/loader/src/tests.rs

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Mar 14, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 14, 2024
@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Mar 14, 2024
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8278533920

Details

  • 123 of 212 (58.02%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.145%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/loader/src/util.rs 56 57 98.25%
kclvm/api/src/service/capi.rs 1 4 25.0%
kclvm/runtime/src/stdlib/builtin_api.rs 0 3 0.0%
kclvm/loader/src/option.rs 35 39 89.74%
kclvm/api/src/service/jsonrpc.rs 0 7 0.0%
kclvm/api/src/service/service_impl.rs 0 29 0.0%
kclvm/sema/src/builtin/option.rs 0 42 0.0%
Totals Coverage Status
Change from base Build 8250547315: 0.2%
Covered Lines: 44914
Relevant Lines: 62255

💛 - Coveralls

@Peefy Peefy merged commit 88553f9 into kcl-lang:main Mar 14, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] [API] How can i get all params (option function call) from the kcl code
3 participants