Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git in kcl docker image #1156

Merged
merged 1 commit into from
Mar 23, 2024
Merged

add git in kcl docker image #1156

merged 1 commit into from
Mar 23, 2024

Conversation

wilsonwang371
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1155

2. What is the scope of this PR (e.g. component or file name):

scripts/docker

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

add git to the kcl docker image

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

No test case is needed for this change.

Copy link

github-actions bot commented Mar 23, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Peefy
Copy link
Contributor

Peefy commented Mar 23, 2024

Hello @wilsonwang371

Thank you for the issue catch contribution. Please sign the DCO. I'll merge this PR.

@wilsonwang371
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@wilsonwang371
Copy link
Contributor Author

recheck

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Mar 23, 2024
Signed-off-by: Wilson Wang <wilson.wang@bytedance.com>
@Peefy Peefy merged commit 19ad8ca into kcl-lang:main Mar 23, 2024
6 of 8 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8399682135

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.323%

Totals Coverage Status
Change from base Build 8386633553: 0.0%
Covered Lines: 45089
Relevant Lines: 62344

💛 - Coveralls

@wilsonwang371
Copy link
Contributor Author

@Peefy are we going to make a new kcl docker image release soon?

@Peefy
Copy link
Contributor

Peefy commented Mar 23, 2024

Yes. You can use docker pull kcllang/kcl to get the latest image that contains git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue of KCL integration with ArgoCD
3 participants