Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file.exsits and file.abs functions #1157

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #1049

  • feat: add file.exsits and file.abs functions

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/builtin/system_module.rs
  • kclvm/runtime/src/file/mod.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/api/src/service/service_impl.rs
  • kclvm/loader/src/snapshots/kclvm_loader__tests__**.snap
  • test/grammar/builtins/file/exists/main.k

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added enhancement New feature or request module labels Mar 25, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 25, 2024
@Peefy Peefy requested a review from zong-zhe March 25, 2024 03:38
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Mar 25, 2024

Pull Request Test Coverage Report for Build 8414738156

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 84 (33.33%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 72.277%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/_kclvm_addr.rs 0 2 0.0%
kclvm/runtime/src/value/val_args.rs 0 16 0.0%
kclvm/runtime/src/file/mod.rs 0 38 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/runtime/src/file/mod.rs 1 0.0%
Totals Coverage Status
Change from base Build 8399712476: -0.05%
Covered Lines: 45117
Relevant Lines: 62422

💛 - Coveralls

@Peefy Peefy merged commit dce6f11 into kcl-lang:main Mar 25, 2024
8 checks passed
@Peefy Peefy deleted the feat-file-abs-and-exists-func branch March 25, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] KCL builtin file system package
3 participants