feat: add file.mkdir and file.delete functions #1271

shruti2522 · 2024-05-03T22:48:46Z

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kcl-lang/kcl/kclvm

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Added kclvm_mkdir and kclvm_delete module functions.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

N
Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

Peefy · 2024-05-04T06:44:51Z

A reference PR to add more functions for the file module. #1157

shruti2522 · 2024-05-04T09:07:20Z

Ah, got it now. While going through the issue, I supposed them to be cli functions, that's why I made changes to the cli.

coveralls · 2024-05-04T09:23:57Z

Pull Request Test Coverage Report for Build 8951702386

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

30 of 68 (44.12%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 71.41%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
kclvm/runtime/src/file/mod.rs	0	38	0.0%

Totals
Change from base Build 8949502527:	-0.03%
Covered Lines:	52784
Relevant Lines:	73917

💛 - Coveralls

shruti2522 · 2024-05-04T10:28:23Z

Ready for review @Peefy

Peefy · 2024-05-04T10:32:11Z

Could you please add more tests and code for the resolver like this PR #1157

shruti2522 · 2024-05-04T15:08:05Z

added the tests @Peefy, please have a look

Peefy · 2024-05-04T15:14:24Z

kclvm/sema/src/builtin/system_module.rs

@@ -1638,6 +1638,34 @@ register_file_member! {
        false,
        None,
    )
+    mkdir => Type::function(
+        None,
+        Type::str_ref(),


Peefy · 2024-05-04T15:14:33Z

kclvm/sema/src/builtin/system_module.rs

+    )
+    delete => Type::function(
+        None,
+        Type::str_ref(),


Peefy · 2024-05-04T15:15:29Z

test/grammar/builtins/file/delete/stdout.golden

@@ -0,0 +1 @@
+delete: 'failed to delete 'test_dir': No such file or directory'


You can add the stderr test suite.

Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests added Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests updated Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated test cases Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated kclvm loader snaps Signed-off-by: shruti2522 <shruti.apc01@gmail.com> added stderr output Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

shruti2522 · 2024-05-04T16:00:59Z

made the changes @Peefy

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

Peefy

LGTM

* feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests added Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests updated Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated test cases Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated kclvm loader snaps Signed-off-by: shruti2522 <shruti.apc01@gmail.com> added stderr output Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> * updated stdout Signed-off-by: shruti2522 <shruti.apc01@gmail.com> --------- Signed-off-by: shruti2522 <shruti.apc01@gmail.com> Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>

shruti2522 force-pushed the module-functions branch 2 times, most recently from 7fa580b to d1cb43b Compare May 3, 2024 23:50

shruti2522 force-pushed the module-functions branch 2 times, most recently from 143f196 to a37fe21 Compare May 4, 2024 10:23

shruti2522 marked this pull request as ready for review May 4, 2024 10:27

shruti2522 force-pushed the module-functions branch from 4cdf55f to 24673ce Compare May 4, 2024 14:35

Peefy reviewed May 4, 2024

View reviewed changes

shruti2522 force-pushed the module-functions branch from 856216e to b4ef566 Compare May 4, 2024 15:58

shruti2522 changed the title ~~feat: extend module functions~~ feat: add file.mkdir and file.delete functions May 4, 2024

updated stdout

812b89c

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

Peefy approved these changes May 4, 2024

View reviewed changes

Peefy merged commit e9e54de into kcl-lang:main May 4, 2024
6 of 8 checks passed

dennybaa mentioned this pull request May 8, 2024

[bug] file mkdir and delete don't seem to work #1300

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add file.mkdir and file.delete functions #1271

feat: add file.mkdir and file.delete functions #1271

shruti2522 commented May 3, 2024 •

edited

Peefy commented May 4, 2024

shruti2522 commented May 4, 2024

coveralls commented May 4, 2024 •

edited

shruti2522 commented May 4, 2024

Peefy commented May 4, 2024

shruti2522 commented May 4, 2024

Peefy May 4, 2024

Peefy May 4, 2024

Peefy May 4, 2024

shruti2522 commented May 4, 2024

Peefy left a comment

		@@ -0,0 +1 @@
		delete: 'failed to delete 'test_dir': No such file or directory'

feat: add file.mkdir and file.delete functions #1271

feat: add file.mkdir and file.delete functions #1271

Conversation

shruti2522 commented May 3, 2024 • edited

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

Peefy commented May 4, 2024

shruti2522 commented May 4, 2024

coveralls commented May 4, 2024 • edited

Pull Request Test Coverage Report for Build 8951702386

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

shruti2522 commented May 4, 2024

Peefy commented May 4, 2024

shruti2522 commented May 4, 2024

Peefy May 4, 2024

Choose a reason for hiding this comment

Peefy May 4, 2024

Choose a reason for hiding this comment

Peefy May 4, 2024

Choose a reason for hiding this comment

shruti2522 commented May 4, 2024

Peefy left a comment

Choose a reason for hiding this comment

shruti2522 commented May 3, 2024 •

edited

coveralls commented May 4, 2024 •

edited