Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lambda in schema function calling for the evaluator #1236

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 20, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: lambda in schema function calling for the evaluator

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator/src/func.rs
  • kclvm/evaluator/src/lib.rs
  • kclvm/evaluator/src/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • .github/workflows/build-test-macos-arm64.yml
  • test/grammar/lambda/in_schema_10/main.k
  • test/grammar/lambda/in_schema_9/main.k

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added bug Something isn't working evaluator labels Apr 20, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Apr 20, 2024
@Peefy Peefy merged commit ea291e1 into kcl-lang:main Apr 20, 2024
7 of 8 checks passed
@Peefy Peefy deleted the fix-evaluator-lambda-in-schema branch April 20, 2024 07:57
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8763515881

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 13 (76.92%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 71.403%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/lib.rs 0 1 0.0%
kclvm/evaluator/src/func.rs 8 10 80.0%
Totals Coverage Status
Change from base Build 8756091603: 0.001%
Covered Lines: 52628
Relevant Lines: 73706

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working evaluator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants