get_schema_type function will now return SchemaType instances with base schema information included
#1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Peefy
added a commit
to kcl-lang/cla.db
that referenced
this pull request
May 4, 2024
|
Please sign the DCO and fix CI |
…ype` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com>
Signed-off-by: utnim2 <mintugogoi567@gmail.com>
Signed-off-by: utnim2 <mintugogoi567@gmail.com>
Pull Request Test Coverage Report for Build 8949066072Details
💛 - Coveralls |
shruti2522
added a commit
to shruti2522/kcl
that referenced
this pull request
May 4, 2024
Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
shruti2522
added a commit
to shruti2522/kcl
that referenced
this pull request
May 4, 2024
Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
shruti2522
added a commit
to shruti2522/kcl
that referenced
this pull request
May 4, 2024
Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests added Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests updated Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
shruti2522
added a commit
to shruti2522/kcl
that referenced
this pull request
May 4, 2024
Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests added Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests updated Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated test cases Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated kclvm loader snaps Signed-off-by: shruti2522 <shruti.apc01@gmail.com> added stderr output Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
Peefy
pushed a commit
that referenced
this pull request
May 4, 2024
* feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests added Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests updated Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated test cases Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated kclvm loader snaps Signed-off-by: shruti2522 <shruti.apc01@gmail.com> added stderr output Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> * updated stdout Signed-off-by: shruti2522 <shruti.apc01@gmail.com> --------- Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
JeevaRamanathan
pushed a commit
to JeevaRamanathan/kcl
that referenced
this pull request
May 7, 2024
…h base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
JeevaRamanathan
pushed a commit
to JeevaRamanathan/kcl
that referenced
this pull request
May 7, 2024
* feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> corrected formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated formatting Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated linker.rs feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> format checking Signed-off-by: shruti2522 <shruti.apc01@gmail.com> `get_schema_type` function will now return `SchemaType` instances with base schema information included (kcl-lang#1272) * `get_schema_type` and `get_full_schema_type` will now return `SchemaType` instance Signed-off-by: utnim2 <mintugogoi567@gmail.com> * added the recursive function Signed-off-by: utnim2 <mintugogoi567@gmail.com> * fixed the types Signed-off-by: utnim2 <mintugogoi567@gmail.com> --------- Signed-off-by: utnim2 <mintugogoi567@gmail.com> feat: extend file module functions mkdir and delete Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests added Signed-off-by: shruti2522 <shruti.apc01@gmail.com> tests updated Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated test cases Signed-off-by: shruti2522 <shruti.apc01@gmail.com> updated kclvm loader snaps Signed-off-by: shruti2522 <shruti.apc01@gmail.com> added stderr output Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: added mkdir and delete module functions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> * updated stdout Signed-off-by: shruti2522 <shruti.apc01@gmail.com> --------- Signed-off-by: shruti2522 <shruti.apc01@gmail.com> Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix [Enhancement] GetSchemaType API provides inheritance information on schema #1215
2. What is the scope of this PR (e.g. component or file name):
kclvm/query/src/query.rskclvm/spec/gpyrpc/gpyrpc.protokclvm/api/src/service/ty.rs3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
the
get_schema_typefunction will returnSchemaTypeinstances with base schema information included, while theget_full_schema_typefunction will returnSchemaTypeinstances with the complete inheritance hierarchy resolved4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
N