Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance lsp diags. #1371

Merged
merged 2 commits into from
May 28, 2024
Merged

enhance lsp diags. #1371

merged 2 commits into from
May 28, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented May 28, 2024

Change the return type of function compile_with_params from Result<(Program, IndexSet, GlobalState)> to (IndexSet, Result<(Program, GlobalState)>)). Returns the discovered diags when compilation fails.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Change the return type of function compile_with_params from Result<(Program, IndexSet, GlobalState)> to (IndexSet, Result<(Program, GlobalState)>)). Returns the discovered diags when compilation fails.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…arams` from Result<(Program, IndexSet<Diagnostic>, GlobalState)> to (IndexSet<Diagnostic>, Result<(Program, GlobalState)>)). Returns the discovered diags when compilation fails.

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added the lsp label May 28, 2024
Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 22e472f into kcl-lang:main May 28, 2024
8 of 10 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9264238597

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 85 of 102 (83.33%) changed or added relevant lines in 4 files are covered.
  • 133 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.1%) to 70.994%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/util.rs 27 34 79.41%
kclvm/tools/src/LSP/src/state.rs 35 45 77.78%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/state.rs 1 81.92%
kclvm/driver/src/tests.rs 4 99.03%
kclvm/sema/src/core/symbol.rs 6 46.8%
kclvm/ast/src/config.rs 7 0.0%
kclvm/api/src/service/jsonrpc.rs 9 0.0%
kclvm/api/src/capi_test.rs 9 97.09%
kclvm/config/src/modfile.rs 10 94.01%
kclvm/driver/src/toolchain.rs 10 88.12%
kclvm/api/src/service/capi.rs 19 76.54%
kclvm/driver/src/lib.rs 20 81.88%
Totals Coverage Status
Change from base Build 9263051754: -0.1%
Covered Lines: 54347
Relevant Lines: 76552

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants