Feat(compiler-base-error): reuse rustc_error 'StyledBuffer' in compiler-base. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zong-zhe
added
enhancement
Peefy
previously approved these changes
Aug 9, 2022
Pull Request Test Coverage Report for Build 2832645236
💛 - Coveralls |
ldxdl
reviewed
Aug 9, 2022
ldxdl
reviewed
Aug 9, 2022
ldxdl
reviewed
Aug 9, 2022
Peefy
reviewed
Aug 9, 2022
Peefy
reviewed
Aug 10, 2022
|
LGTM |
…tions. Reuse 'styled_buffer.rs' in 'rustc_errors', and 'styled_buffer.rs' has been modified to fit the feature of 'Compiler-Base'. - add method 'appendl()' and 'pushs()' to 'StyledBuffer'. - replaced the `enum Style` with generics `T: Clone + PartialEq + Eq + Style` to support extending more styles. - add some test cases for 'StyledBuffer'. issue #115 add comments for `putl()` and `appendl()` add comments to trait Style add more README use generic to replace `dyn trait` rename `putl` to `pushs`. rename `appendl` to `append_last_line`. rename `render_style` to `render_style_to_color_spec`. fix comments mistake rename `append_last_line` to `appendl`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
issue #115
2. What is the scope of this PR (e.g. component or file name):
compiler_base/3rdparty/rustc_errors
compiler_base/3rdparty/rustc_span
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This is the first step for Compiler-Base-Error in issue #115.
Reuse 'styled_buffer.rs' in 'rustc_errors', and 'styled_buffer.rs' has been modified to fit the feature of 'Compiler-Base'.
Add method 'appendl()' and 'putl()' to 'StyledBuffer',they can adjust the line and column in the 'StyleBuffer' according to the length of the input string.
Replaced the 'enum Style' with 'trait Style' in 'StyledBuffer' to support extending more styles. And 'trait Style' is defined in compiler_base/3rdparty/rustc_errors/src/lib.rs.
Add some test cases for 'StyledBuffer'.
Add 'LICENSE' and 'README.md' in compiler_base/3rdparty/rustc_errors/src/ for reusing rustc source code.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
The test case is in the 'compiler_base/lib.rs', and shows how the 'StyledBuffer' work.
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.