Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(compiler-base-error): CodeSnippet component generates the line … #249

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Fix(compiler-base-error): CodeSnippet component generates the line … #249

merged 2 commits into from
Oct 20, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler_base_error

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

In CodeSnippet components, the line number plus one.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…number plus one.

In `CodeSnippet` components, the line number plus one.

issue #115
@zong-zhe zong-zhe added bug Something isn't working fix labels Oct 19, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 19, 2022
@zong-zhe zong-zhe self-assigned this Oct 19, 2022
@coveralls
Copy link
Collaborator

coveralls commented Oct 19, 2022

Pull Request Test Coverage Report for Build 3280760706

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-5.5%) to 53.571%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/ty/context.rs 1 93.2%
Totals Coverage Status
Change from base Build 3272275678: -5.5%
Covered Lines: 14702
Relevant Lines: 27444

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amyXia1994 amyXia1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amyXia1994 amyXia1994 merged commit 51b374d into kcl-lang:main Oct 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants