Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolver ty mismatch in the assign statement with the schema type annotation #384

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 18, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #325

2. What is the scope of this PR (e.g. component or file name):

Refactor

  • kclvm/sema/src/resolver/global.rs
  • kclvm/sema/src/resolver/node.rs

Fix

  • must_assignable_to call at kclvm/sema/src/resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/var_type_annotation/type_fail_10/main.k
  • test/grammar/types/var_type_annotation/type_fail_11/main.k
  • test/grammar/types/var_type_annotation/type_fail_12/main.k

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the resolver label Jan 18, 2023
@Peefy Peefy self-assigned this Jan 18, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 18, 2023

Pull Request Test Coverage Report for Build 3945569232

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-29.1%) to 61.467%

Totals Coverage Status
Change from base Build 3939148325: -29.1%
Covered Lines: 21431
Relevant Lines: 34866

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit c03012b into kcl-lang:main Jan 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
@Peefy Peefy deleted the fix-resolver-ty-mismatch branch January 29, 2023 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The resolver did not handle type mismatch correctly on the schema
4 participants