Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more test cases on format tool behavior #786

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #627

2. What is the scope of this PR (e.g. component or file name):

testdata:

  • kclvm/tools/src/format/test_data/format_data/
  • kclvm/tools/src/format/tests.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

add more test cases on format tool behavior

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@amyXia1994 amyXia1994 requested a review from Peefy October 18, 2023 04:13
@coveralls
Copy link
Collaborator

coveralls commented Oct 18, 2023

Pull Request Test Coverage Report for Build 6556645963

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.2%) to 70.661%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6546481370: -17.2%
Covered Lines: 36586
Relevant Lines: 51777

💛 - Coveralls

@Peefy Peefy changed the title fix: add more test cases on format tool behavior test: add more test cases on format tool behavior Oct 18, 2023
@Peefy Peefy added tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. test labels Oct 18, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Oct 18, 2023
Signed-off-by: xiarui.xr <xiarui1994@gmail.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 834c7b5 into kcl-lang:main Oct 18, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants