Integrate the CRD puller into the cluster controller #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
|
cc @imjasonh |
imjasonh
approved these changes
Apr 19, 2021
| @@ -142,7 +142,7 @@ func main() { | |||
| "admin": {Cluster: "admin", AuthInfo: "loopback"}, | |||
| "user": {Cluster: "user", AuthInfo: "loopback"}, | |||
| } | |||
| clientConfig.CurrentContext = "user" | |||
| clientConfig.CurrentContext = "admin" | |||
There was a problem hiding this comment.
Does this mean we can remove the text about using this context?
There was a problem hiding this comment.
If you and @smarterclayton agree with this change here, then yes :-)
There was a problem hiding this comment.
So I assume that "silent is consent" @smarterclayton :-) and will merge the PR tomorrow if no more comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the CRD Puller into the cluster controller in order to pull some resources of a physical cluster (pods / deployment) inside the KCP and register them as CRDs when a physical cluster is joining.
Of course this is a very basic, minimal implementation, with no negociation at all in case of resource schema conflicts.
But this is sufficient to implement the case when adding a physical cluster brings back
podsanddeploymentsresources to the KCP.