🌱 test/e2e: stop dumping YAML #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
changed the title
ncdc
approved these changes
Oct 27, 2022
Dumping the full object to stdout is never what someone wants to see when they break a test. Specify what it is that needs to be true, and provide a clear message when it is not. If you must have the whole object, add it to artifacts. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/fix-assertion
branch
from
50d3d30
to
804d599
Compare
|
New changes are detected. LGTM label has been removed. |
openshift-ci
bot
added
the
approved
ncdc
approved these changes
Oct 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test e2e-multiple-runs |
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping the full object to stdout is never what someone wants to see when they break a test. Specify what it is that needs to be true, and provide a clear message when it is not. If you must have the whole object, add it to artifacts.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com