cluster: scope-down dynamic and discovery clients #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
changed the title
sttts
reviewed
Nov 23, 2021
sttts
reviewed
Nov 23, 2021
ncdc
reviewed
Nov 23, 2021
|
Fixes #236 |
|
Need to put the fixes details in the PR description to have it auto-close the issue on merge |
stevekuznetsov
force-pushed
the
skuznets/use-cluster-clients
branch
5 times, most recently
from
deb4ea4
to
04557c8
Compare
|
This is now just failing on syncing data back from the pcluster to the kcp, with: |
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Instead of expecting a separate kubeconfig context entry for every possible logical cluster we need to operate over, use the client-go helpers for scoping down a cluster-less dynamic client or discovery client to a cluster-scoped one, as needed. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/use-cluster-clients
branch
from
04557c8
to
0aae591
Compare
|
OK, should be working now. Added an e2e. |
stevekuznetsov
force-pushed
the
skuznets/use-cluster-clients
branch
from
0aae591
to
f531d8a
Compare
|
Note: I will move both this and the sharding "e2e" into the Go-based tests once the framework lands. I know the shell is quite the mouthful but let's just use it as a stop-gap until we have the better approach. |
sttts
reviewed
Nov 24, 2021
sttts
reviewed
Nov 24, 2021
| @@ -27,7 +27,14 @@ func deepEqualStatus(oldObj, newObj interface{}) bool { | |||
| return equality.Semantic.DeepEqual(oldStatus, newStatus) | |||
| } | |||
|
|
|||
| const statusSyncerAgent = "kcp#status-syncer/v0.0.0" | |||
There was a problem hiding this comment.
this is something I would like to see everywhere, for every controller and component we build. Is therre a good place to add this centrally? E.g. in the kcp startup code?
There was a problem hiding this comment.
Yes, but //TODO?
Merged
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
When you have lots of clients going in both directions it's nice to be able to tell what's going where and why. The user-agent helps with that. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/use-cluster-clients
branch
from
f531d8a
to
7fa4fa6
Compare
sttts
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster: scope-down dynamic and discovery clients
Instead of expecting a separate kubeconfig context entry for every
possible logical cluster we need to operate over, use the client-go
helpers for scoping down a cluster-less dynamic client or discovery
client to a cluster-scoped one, as needed.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
requires kcp-dev/kubernetes#22
Fixes #236