Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACK: scope dynamic and discovery clients by cluster #22

Conversation

stevekuznetsov
Copy link

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

@stevekuznetsov stevekuznetsov force-pushed the skuznets/clustered-dyanmic-client branch from 5b04ec7 to 2c0b19c Compare November 23, 2021 00:23
@stevekuznetsov stevekuznetsov changed the title HACK: client: add a clustered dynamic client HACK: scope dynamic and discovery clients by cluster Nov 23, 2021
Copy link

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small comment. 👍

@@ -71,16 +103,16 @@ func NewForConfig(inConfig *rest.Config) (Interface, error) {
return nil, err
}

return &dynamicClient{client: restClient}, nil
return &DyanmicClient{scopedClient: &scopedClient{client: restClient}}, nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: dyanmic

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/clustered-dyanmic-client branch from 2c0b19c to 5ec8e3b Compare November 23, 2021 19:44
@stevekuznetsov
Copy link
Author

@imjasonh updated!

@imjasonh imjasonh merged commit d0ac9bf into kcp-dev:feature-logical-clusters-1.22 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants