Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with stackoverflow error when n is pressed twice #160

Closed
deepu105 opened this issue Jan 25, 2022 · 4 comments
Closed

Crash with stackoverflow error when n is pressed twice #160

deepu105 opened this issue Jan 25, 2022 · 4 comments

Comments

@deepu105
Copy link
Contributor

From version 0.2.7 onwards, the app crashes when key n is pressed more than once. Check if its related to cache improvements done on 0.2.7

@omid
Copy link
Contributor

omid commented Jan 25, 2022

It also happens on earlier versions, I even tried the docker version of 0.0.4
Seems line on release, it doesn't end to a crash, but 100% CPU usage.

@deepu105
Copy link
Contributor Author

Hmm, strange, you are right, it goes into an infinite loop.

@omid
Copy link
Contributor

omid commented Jan 25, 2022

We can easily hide it behind if app.get_current_route().active_block != ActiveBlock::Namespaces { ... }
But it's better to find the root cause of the issue and fix it

@deepu105
Copy link
Contributor Author

I might have an idea whats wrong, but have to check code and confirm. There was some special handling for the namespace route so that the resource tab route is rendered properly when hitting ns route using previous route value and that might be causing the loop and if that's the cause your solution might be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants