Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit and refactor type handling in dialects #545

Open
kdhrubo opened this issue May 7, 2024 · 2 comments
Open

Revisit and refactor type handling in dialects #545

kdhrubo opened this issue May 7, 2024 · 2 comments

Comments

@kdhrubo
Copy link
Collaborator

kdhrubo commented May 7, 2024

This is a crucial component and should be handled with care and tests. Better to address one dialect at a time.
Here the changes required.

  1. Change package name to com.homihq.db2rest.jdbc.dialect
  2. Review method processTypes to ensure that there is no missing data type. This method converts incoming data attributes from REST API into data attributes with proper types that database understands. Typically JDBC drivers provide such mapping of Java types to DB data types.
  3. The SQL builder must consult this class to get the SQL generation template files. There is need for a new method that takes in a key and returns the appropriate files as a resource. The dialect class can cache these resources.
  4. The reverse data type change - i.e when data is fetched from DB the JDBC type to Java type conversion or any formatting needs to happen in this class.

I would suggest treating this as an epic and creating smaller stories per database to implement these 5 changes.

@stephanpio1
Copy link
Contributor

Hey I’d like to work on issue. Can you share more details?

@kdhrubo
Copy link
Collaborator Author

kdhrubo commented Oct 9, 2024

@stephanpio1 - done, let us know what you think. May be implement this in small steps 1 change at a time and add tests to validate and endure no integration test is fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants