Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

[Insight] exit() and die() functions should be avoided - in CronWorker.php, line 38 #2

Closed
kduma opened this issue Feb 1, 2015 · 0 comments
Labels

Comments

@kduma
Copy link
Collaborator

kduma commented Feb 1, 2015

in CronWorker.php, line 38

This line stops the execution flow, without explanation. If this is for debug, you should remove it. If this is to deal with an error, use exceptions instead.

            {
                $connection = $this->manager->connection($connectionName);
                $job = $this->getNextJob($connection, $queue);
                if (is_null($job))
                {
                    exit;
                }
                $this->process(
                    $this->manager->getName($connectionName), $job, $maxTries, $delay
                );
            }

Posted from SensioLabsInsight

@kduma kduma added the bug label Feb 1, 2015
@kduma kduma closed this as completed Jun 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant