Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic registration of dependencies #11

Closed
stekycz opened this issue Apr 5, 2013 · 3 comments
Closed

Automatic registration of dependencies #11

stekycz opened this issue Apr 5, 2013 · 3 comments

Comments

@stekycz
Copy link
Contributor

stekycz commented Apr 5, 2013

It would be nice if OrmExtension::register($configurator) could register extensions which are dependencies for this extension. It means Kdyby\Event and Kdyby\Console.
@vojtech-dobes
Copy link

I think better is to throw exception and tell developer to register them. Otherwise it's some secret magic behing, and developer even doesn't have to realize he uses them...

@fprochazka
Copy link
Member

@vojtech-dobes is right, I've reverted the 26833ab and now I'm asking the user to enable it manually

@fprochazka
Copy link
Member

Kdyby/Console is not required for the Kdyby/Doctrine to run. It's quite essential, but not a direct dependency. Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fprochazka @vojtech-dobes @stekycz