Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrmExtension EntityMapping configuration logic ambiguity #43

Open
mishak87 opened this issue Sep 5, 2013 · 4 comments
Open

OrmExtension EntityMapping configuration logic ambiguity #43

mishak87 opened this issue Sep 5, 2013 · 4 comments
Labels
Milestone

Comments

@mishak87
Copy link
Contributor

mishak87 commented Sep 5, 2013

Current behaviour is a bit confusing.

Configuration of entity mapping is ambiguous because it can be added globally via provider from extensions or per instance via configuration to EntityManager. But the global from extensions overrides the specific from configuration.

@Majkl578
Copy link
Member

Majkl578 commented Sep 5, 2013

Overrides? I see array_merge there.

@mishak87
Copy link
Contributor Author

mishak87 commented Sep 5, 2013

Sorry my bad, I was already editing the issue, but will reply bellow instead.

Then it is just a minor issue. If I want another EntityManager with only specific Entities I will get those + global from provider. There is no way to disable them in config. So specific configuration does not make much sense. I guess there might be some edge cases where it makes sense, but I have to jet discover them.

@fprochazka
Copy link
Member

@mishak87 I hope noone is that dumb to override his mappings. But there might be a way to make it bit safer.

@fprochazka
Copy link
Member

In v4.0 Kdyby will drop providers and add some extension methods, similar to DecoratorExtension.php.

@fprochazka fprochazka added this to the v4.0 milestone May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants