Connection::insert is escaping identifiers - inconsistency and compatibility break

[mishak87]

Code

Current state is that insert quotes and update and delete don't.

Either all functions should quote or it should be delegated to utility class DirectDataPersistor<insert,update,delete> (preferably with better name).

[fprochazka]

All should quote :)

[stekycz]

This should be fixed in Doctrine itself, isn't? Original implementation of insert also does not escape. And it also does something more then Kdyby implementation.

Why is method insert overriden anyway?

[fprochazka]

Doctrine thinks this is a feature, I think we should override those methods and fix them.

[stekycz]

I think overriding is temporary solution if it can be in Doctrine.

[fprochazka]

Temporary solution is better than none. And I'm telling you, they won't make it easy for you to push this feature directly to doctrine. But hey, you can try and I will be glad if you succeed.

[stekycz]

I may will try it because it looks for me easier then keep own updated methods in sync with Doctrine. However if they will be too hard against this feature I will accept it.