Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with hot module replacement #109

Closed
Dmitri801 opened this issue Jun 29, 2020 · 2 comments
Closed

Usage with hot module replacement #109

Dmitri801 opened this issue Jun 29, 2020 · 2 comments

Comments

@Dmitri801
Copy link

Is there further configuration needed for react hot module replacement ( https://github.com/gaearon/react-hot-loader) to work? I have it correctly working when editing a React component, however when I edit a kea logic I get this error
Screen Shot 2020-06-28 at 8 47 35 PM

Thanks for the help!

@mariusandra
Copy link
Member

Hey, yeah, I think this doesn't work out of the box. We'd need some way to get a signal from HMR that the logic should be swapped out and then implement code that does the swapping. I think. It would be sweet to get this to work, but I don't see how I can find time to work on it now. My main priority now is to get TypeScript support out the door. :)

@mariusandra
Copy link
Member

We have some form of react fast refresh support now in the library. It's recommended to migrate to it anyway from the other HOT approaches, so closing this issue :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants