Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseURL incorrect #45

Closed
i-tengfei opened this issue Jul 13, 2022 · 2 comments
Closed

baseURL incorrect #45

i-tengfei opened this issue Jul 13, 2022 · 2 comments

Comments

@i-tengfei
Copy link

let baseURL = URL(string: "https://gitlab.com/api/v4")
URL(string: "/test", relativeTo: baseURL)?.absoluteString

expect
https://gitlab.com/api/v4/test

result
https://gitlab.com/test

2022-07-14 05 19 14

73476a8

@kean
Copy link
Owner

kean commented Jul 13, 2022

Thanks for the report, @i-tengfei. I just switched to this API in the pre-release apparently fully without releasing how it worked. I'm going to revert the change. The baseURL should allow you to provide URLs with a path.

@kean
Copy link
Owner

kean commented Jul 14, 2022

Fixed in #46. I added your example as a unit test. After it's merged, please install from the main branch. There will be a new RC, but not immediately.

@kean kean closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants