-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcode #40
Comments
Hey! Yep, I've investigated this issue some time ago. Nuke does feature Bitcode support but Carthage 0.9.3 was completely broken in terms of Bitcode, see the discussion in Carthage/Carthage#535. New version (0.9.4) does seem to feature some sort of workaround, but I haven't tested it yet. Are you using the latest version (0.9.4)? I would recommend to either use CocoaPods (which is excellent in terms of supporting new stuff as soon as it is available) or just disable Bitcode all together (which is the safest thing to do right now). |
I'm using 0.9.4 carthage and Xcode 7.1, which seems to have gotten rid of the option to enable/disable bit code... trying to figure that out right now. In any event, I think bit code is required for tvos (inexplicably). |
Regarding enabling/disabling bit code, I added ENABLE_BITCODE=YES manually to my project.pbxproj and rebuilt the Nuke with carthage and still the same error back from the App Store. I switched to cocoa pods and now it works... |
Carthage readme states that their script with workarounds now also contains a workaround for Bitcode. Please reopen if there are any issues with Nuke (not Carthage). |
To be clear, I understood this to a problem with Nuke's Carthage config, which is why I opened this bug. I couldn't get it working with Carthage (including those new directions), so I can't really rule that out. Sorry I can't be of more help. |
I'm getting an error after submitting a tvos app to app store: Invalid Executable - The executable 'Lumbar.app/Frameworks/Nuke.framework/Nuke' does not contain bitcode.
Based on this issue (Carthage/Carthage#535), it seems that Nuke would need to enable bit code.
The text was updated successfully, but these errors were encountered: