Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Catalyst support #3

Closed
vox-humana opened this issue Feb 22, 2021 · 10 comments
Closed

Mac Catalyst support #3

vox-humana opened this issue Feb 22, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@vox-humana
Copy link
Collaborator

A feature request for adding Catalyst support. Currently XCFrameworks in Pulse distribution contain only iOS and simulator frameworks.

It needs an extra build for -destination 'platform=macOS,arch=x86_64,variant=Mac Catalyst' according to this beautiful guide https://pspdfkit.com/blog/2020/supporting-xcframeworks/

@vox-humana vox-humana added the enhancement New feature or request label Feb 22, 2021
@kean
Copy link
Owner

kean commented Feb 22, 2021

Got it, thanks for the details. I'll push a version with Catalyst support soon. And the initial macOS version.

@kean
Copy link
Owner

kean commented Feb 22, 2021

I'm using swift-create-xcframework to create xcframeworks, apparently there is some issue with catalyst https://github.com/unsignedapps/swift-create-xcframework/issues/27. I don't know yet if it's the issue on my side or in the script. I can build the package for Catalyst from Xcode just fine.

@vox-humana
Copy link
Collaborator Author

Thanks for such an instant reply and for the bug reference 👀

@kean
Copy link
Owner

kean commented Feb 22, 2021

0.9.5 shipped without Catalyst. It's getting a bit late, I'll see what I can do some time this week.

In the meantime, Pulse macOS Alpha is out. It's attached to https://github.com/kean/PulseUI/releases/tag/0.9.5.

@carltongibson
Copy link
Collaborator

carltongibson commented Mar 7, 2021

Hi, thanks for the work; really excited to be using it!

Trying to install for a multi-platform SwiftUI project.

Get this on building:

While building for macOS, no library for this platform was found in  
'/Users/carlton/Library/Developer/Xcode/DerivedData/.../SourcePackages/artifacts/Pulse/PulseCore.xcframework'.

While building for macOS, no library for this platform was found in 
'/Users/carlton/Library/Developer/Xcode/DerivedData/.../SourcePackages/artifacts/Pulse/PulseUI.xcframework'.

Can I confirm whether this is expected limitation at this point?

Package version is 0.9.8.
(I was going to create a new issue, because not Catalyst, but presumably they're solved together? 🤔)

Thanks!

@kean
Copy link
Owner

kean commented Mar 7, 2021

Thank you, and thanks for sponsoring!

Yes, this is an expected limitation. Pulse is currently available in a form of a Swift package for iOS apps and a separate macOS app.

I'll prioritize adding support for other platforms and will try to get a new build ready by the end of the day.

@carltongibson
Copy link
Collaborator

Hey @kean.

Thanks for the quick reply, and no stress. 🙂 it would be nice to have the macOS build but whatever time line that comes on is fine. (It's the weekend!)

Thanks. C.

@kean
Copy link
Owner

kean commented Mar 7, 2021

The new release with macOS and Mac Catalyst support is up https://github.com/kean/PulseUI/releases/tag/0.9.9. I also opened a fix for swift-create-xcframework.

@kean kean closed this as completed Mar 7, 2021
@kean
Copy link
Owner

kean commented Mar 7, 2021

(It's the weekend!)

Right, that's when I work on my personal projects 👀

@carltongibson
Copy link
Collaborator

Super. Good work. Thanks for the release @kean 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants