-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading Keda to v2.12.0 the v1beta1.external.metrics.k8s.io API component is not getting updated and its out of sync. #550
Comments
Yup, we have the same issue in our ArgoCD. I think the issue here is that it is trying to enforce the default value, so it never appears in the resource (do
|
Also ran into this, since the value is default and is not configurable in the helm chart should probably just remove it from the manifest. I didn't quite get what the change was fixing during upgrades, though ArgoCD might not have seen this issue since it doesn't use the normal Helm upgrade workflow. If someone runs into this with ArgoCD you can use this ignoreDifferences config: ignoreDifferences:
- group: apiregistration.k8s.io
kind: APIService
jsonPointers:
- /spec/insecureSkipTLSVerify |
@sidewinder12s could you please update our Troubleshooting section in docs with this info? https://keda.sh/docs/2.12/troubleshooting/ |
Actually turns out ArgoCD does need to apply the manifest as is in the chart. Once the upgrade is through you can apply the ignoreDifferences config however. So I think users can either ignore it and wait for the workaround to be removed from the chart or use the ignoreDifferences config. I don't think this issue is very important to flag on general troubleshooting for Keda. Either way I can't commit to OSS repos without going through a legal review with my company. |
Has this been fixed in |
Expected Behavior
After upgrading Keda to v2.12.0 all the components should be in sync .
Actual Behavior
After upgrading Keda to v2.12.0 the v1beta1.external.metrics.k8s.io API component is not getting updated and it shows out of sync. When looking at the desired and the acutal state of the manifest file we could see the insecureSkipTLSVerify: false this value in desrired manifest is not getting picked up by argocd
PR where insecureSkipTLSVerify: false was added explicitly https://github.com/kedacore/charts/pull/520/files
Steps to Reproduce the Problem
Specifications
can you please suggest any workaround which can fix this issue as in production env the Keda application shows outofsync due to this issue and this needs to be resolved at earliest.
The text was updated successfully, but these errors were encountered: