Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.12.0 pushed to Helm repository with CRLF endings #574

Open
zmarouf opened this issue Nov 27, 2023 · 4 comments
Open

Version 2.12.0 pushed to Helm repository with CRLF endings #574

zmarouf opened this issue Nov 27, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@zmarouf
Copy link

zmarouf commented Nov 27, 2023

The 2.12.0 Helm chart update seems to be pushed with CRLF endings.
Git repository seems okay.

Expected Behavior

LF line terminators when pushing the Chart to the Helm Repository.

Actual Behavior

CRLF, LF line terminators according to file

  • Using Helm template
    Screenshot 2023-11-27 at 11 15 52

  • In a repository that pulls the chart via Carvel vendir
    Screenshot 2023-11-27 at 11 21 21

  • This breaks consistency with tooling that monitors Chart updates.

  • Git warns of changes on every single file e.g

warning: in the working copy of 'charts/keda/templates/cert-manager/keda-tls-certificate.yaml', CRLF will be replaced by LF the next time Git touches it

Steps to Reproduce the Problem

  1. helm template kedacore/keda --version 2.11.0 -n keda > keda.2.11.0.yaml
  2. helm template kedacore/keda --version 2.12.0 -n keda > keda.2.12.0.yaml
  3. file keda.2.11.0.yaml keda.2.12.0.yaml
keda.2.11.0.yaml: ASCII text
keda.2.12.0.yaml: ASCII text, with CRLF, LF line terminators

Specifications

  • KEDA Version: 2.12.0
  • Platform & Version: Linux and BSD
  • Kubernetes Version: N/A
  • Scaler(s): N/A
@zmarouf zmarouf added the bug Something isn't working label Nov 27, 2023
@JorTurFer
Copy link
Member

@tomkerkhove @zroubalik , should we push again the chart or just being more care in the future?

@zroubalik
Copy link
Member

I would wait for next releases and make sure to use a proper OS for it ;)

@JorTurFer
Copy link
Member

Maybe we can take this issue as a good reason for deploying somehow the charts in a more automated way, WDYT?

@zroubalik
Copy link
Member

Agree, let's track this somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants