Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Name is not propagated to single Ingress #306

Closed
kadel opened this issue Oct 4, 2017 · 2 comments
Closed

Name is not propagated to single Ingress #306

kadel opened this issue Oct 4, 2017 · 2 comments

Comments

@kadel
Copy link
Member

kadel commented Oct 4, 2017

If only one ingress is defined and doesn't have name the top name level should be used.
This is correctly happening for Services, but not for Ingresses.

input:

name: nginx
annotations:
  foo: deployment

containers:
- image: nginx

services:
- ports:
  - port: 8080
    targetPort: 80

ingresses:
- annotations:
    foo: ingress
  rules:
  - host: nginx.192.168.64.7.nip.io
    http:
      paths:
      - path: /
        backend:
          serviceName: nginx
          servicePort: 8080

output:

▶ ./kedge apply -f nginx.yaml
service "nginx" created
error: error when retrieving current configuration of:
&{0xc4200f6cc0 0xc4202ca5b0 default  STDIN 0xc4202fa638 0xc4202fa638  false}
from server for: "STDIN": resource name may not be empty
kubectl error: failed to execute command: exit status 1

generated ingress:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  creationTimestamp: null
  labels:
    app: nginx
spec:
  rules:
  - host: nginx.192.168.64.7.nip.io
    http:
      paths:
      - backend:
          serviceName: nginx
          servicePort: 8080
        path: /
status:
  loadBalancer: {}
@kadel kadel changed the title Name is not propagated to Ingress Name is not propagated to single Ingress Oct 4, 2017
@concaf
Copy link
Collaborator

concaf commented Oct 4, 2017

Yeah, I realized that there is not fixIngresses function while doing ObjectMeta PR.

@concaf concaf added this to the 0.3.0 milestone Oct 4, 2017
@concaf concaf self-assigned this Oct 4, 2017
@concaf
Copy link
Collaborator

concaf commented Oct 5, 2017

Closed in #310

@concaf concaf closed this as completed Oct 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants