Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending stateful URLS #1736

Closed
1 task
rashidakanchwala opened this issue Feb 5, 2024 · 2 comments · Fixed by #1799
Closed
1 task

Extending stateful URLS #1736

rashidakanchwala opened this issue Feb 5, 2024 · 2 comments · Fixed by #1799

Comments

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Feb 5, 2024

Description

This issue is to solve for this problem #1673

The aims to enhance the stateful URLs to include additional functionalities such as

  • node type filtering,
  • tag filtering, and
  • expanding/collapsing all modular pipelines.

We understand that this may result in longer URLs. Shortening our existing URL states is a priority, even if the resulting URLs are not human-readable.

Below is the current code

export const params = {
  focused: 'focused_id',  (instead we use **fid**) 
  selected: 'selected_id', (instead we use **sid**) 
  selectedName: 'selected_name', (instead we use **sn**) 
  pipeline: 'pipeline_id', (instead we use **pid**) 
  run: 'run_ids', (instead we use **rid**) 
  view: 'view', (instead we use **v**) 
  comparisonMode: 'comparison', (instead we use **cmp**) 
};

Here are some suggestions for the new parameters. For Node Filtering by node types, or tags -- maybe we only mention what we want to hide in the params otherwise params will get very long.

  • To filter by types: type=parameters,dataset (this means only task nodes will be visible)

  • To filter by tags: tag=tagid1,tagid2,tagid3 (this means all nodes with thse tagsIds will be hidden)

  • To expand all: expAll=true/false

  • Include labels so that we can categorise your feature request

@rashidakanchwala
Copy link
Contributor Author

@NeroOkwa @astrojuanlu

@stephkaiser
Copy link

suggestion to also include ability to save pretty name on/off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
3 participants