Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the runtime client still be the old net/rpc client #1

Closed
bvk opened this issue Jul 8, 2018 · 1 comment
Closed

Can the runtime client still be the old net/rpc client #1

bvk opened this issue Jul 8, 2018 · 1 comment

Comments

@bvk
Copy link

bvk commented Jul 8, 2018

This is a really good fix. Thanks for the package.

It is not clear from the project README, if the rpc mechanism still works between a Server instance using github.com/keegancsmith/rpc package and Client instance using the standard net/rpc package. I haven't looked at the implementation yet, so cloud you please clarify?

@keegancsmith
Copy link
Owner

Yes, there are no changes to the wire protocol so is backwards compatible. Cancellation is communicated via a normal net/rpc call (_goRPC_.Cancel). I'll update the documentation to make this clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants