Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Semantic Version #33

Closed
sabrehagen opened this issue Jul 11, 2017 · 1 comment
Closed

Invalid Semantic Version #33

sabrehagen opened this issue Jul 11, 2017 · 1 comment
Labels
bug

Comments

@sabrehagen
Copy link

This seems like one of those cases when the latest tag should be handled gracefully, not an error thrown:

2017-07-11T01:48:40.268550511Z time="2017-07-11T01:48:40Z" level=warning msg="trigger.pubsub: failed to get name and version from image" action=INSERT error="Invalid Semantic Version" tag="gcr.io/stemnapp/alpine-website:latest" 
2017-07-11T01:48:41.821102919Z time="2017-07-11T01:48:41Z" level=info msg="provider.kubernetes: processing event" registry= repository="gcr.io/stemnapp/alpine-website" tag=v0.0.4
@rusenask rusenask mentioned this issue Jul 11, 2017
Merged
@rusenask rusenask added the bug label Jul 11, 2017
@rusenask
Copy link
Collaborator

sorry for that! that "legacy" persing got through me, totally forgot that gcloud pubsub doesn't separate image name from tag.

Should be fixed in https://github.com/rusenask/keel/releases/tag/0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sabrehagen @rusenask