Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keel can't find imagePullSecrets when using helm for some charts #353

Closed
Multiply opened this issue Mar 7, 2019 · 3 comments
Closed

Keel can't find imagePullSecrets when using helm for some charts #353

Multiply opened this issue Mar 7, 2019 · 3 comments

Comments

@Multiply
Copy link

Multiply commented Mar 7, 2019

In the helm integration, there's an assumption that the labels app and release is always set for pods managed by helm/tiller, which is not the case.

Following the best practices for chart labels you'll end up with a different set of labels.

Ideally we should be able to simply set which imagePullSecrets to use, kind of how it seems to have been approached in the beginning, instead of relying on the pods already in the cluster.

This could also fix a potential issue where a deployment/replicaset fails to create pods (due to various reasons), so we're kind of forcing the secrets down to keel.

Another approach would be allowing to override the default docker config using the helm chart that we used to deploy keel in the first place.

@rusenask
Copy link
Collaborator

rusenask commented Mar 7, 2019

hi, at the time of writing helm integration, those were the standard labels that helm would auto create for new charts.
Yeah, I agree regarding the image pull secrets, it should be possible to specify it manually either through labels or helm values.yml

@rusenask
Copy link
Collaborator

Hi, I am bringing it back :)

@rusenask
Copy link
Collaborator

Available in the docs: https://keel.sh/docs/#helm-polling-private-registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants