You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This could also fix a potential issue where a deployment/replicaset fails to create pods (due to various reasons), so we're kind of forcing the secrets down to keel.
Another approach would be allowing to override the default docker config using the helm chart that we used to deploy keel in the first place.
The text was updated successfully, but these errors were encountered:
hi, at the time of writing helm integration, those were the standard labels that helm would auto create for new charts.
Yeah, I agree regarding the image pull secrets, it should be possible to specify it manually either through labels or helm values.yml
In the helm integration, there's an assumption that the labels
app
andrelease
is always set for pods managed by helm/tiller, which is not the case.Following the best practices for chart labels you'll end up with a different set of labels.
Ideally we should be able to simply set which imagePullSecrets to use, kind of how it seems to have been approached in the beginning, instead of relying on the pods already in the cluster.
This could also fix a potential issue where a deployment/replicaset fails to create pods (due to various reasons), so we're kind of forcing the secrets down to keel.
Another approach would be allowing to override the default docker config using the helm chart that we used to deploy keel in the first place.
The text was updated successfully, but these errors were encountered: