Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create view and functionality for creating a new order (FE) #240

Open
Tracked by #46
MariusJulius opened this issue Apr 19, 2023 · 12 comments
Open
Tracked by #46

Create view and functionality for creating a new order (FE) #240

MariusJulius opened this issue Apr 19, 2023 · 12 comments

Comments

@MariusJulius
Copy link
Collaborator

MariusJulius commented Apr 19, 2023

Wiki - flow
Wiki - order fields
Design - create order

To-do:

  • creating create order view and functionality
@MariusJulius MariusJulius changed the title create new order /project (FE) Create view and functionality for creating a new ordert (FE) Apr 19, 2023
@MariusJulius MariusJulius changed the title Create view and functionality for creating a new ordert (FE) Create view and functionality for creating a new order (FE) Apr 19, 2023
@KaarelKa KaarelKa moved this from To groom to Blocked in Tõlkevärav (Translation Hub) May 15, 2023
@KaarelKa
Copy link

@thenouan

  1. Order creation will happen through our API or directly through Camundas ?
  2. If it will be through our API, then do we already know what the names of the fields will be ?

@KaarelKa KaarelKa moved this from Blocked to In Progress in Tõlkevärav (Translation Hub) Aug 1, 2023
@KaarelKa KaarelKa self-assigned this Aug 1, 2023
@KaarelKa
Copy link

KaarelKa commented Aug 9, 2023

  1. Task is semi-done, but most of the BE endpoints needed for this are either missing completely or not working correctly, so parts of the data are mocked and others optimistically use BE endpoints by passing in parameters, which are not yet accepted.

  2. Top section of new order view does not match the new design. It was completed before design changed. Will change it in the future if there is time.

@KaarelKa KaarelKa moved this from In Progress to In Review in Tõlkevärav (Translation Hub) Aug 9, 2023
@KaarelKa KaarelKa moved this from In Review to Ready for Build in Tõlkevärav (Translation Hub) Aug 15, 2023
@MariusJulius
Copy link
Collaborator Author

Few initial comments:

  • for language dropdown selected language should be shown also for source language (as it is for target)
  • language selection dropwdown looks like cut off (add margin?)

@DanBondarenko
Copy link

@MariusJulius @PlaksoBirgit I noticed that the project creation view in Figma does not have an example of project creation forms where "Start date" and "Start time" fields can be entered (for projects whose type allows these fields). The only examples of these fields I found in Figma are in the "Project manager / Edit project details" view.

If the front-end team is aware of this and adds the fields anyway, then this is not a problem. However, if the front-end team is not aware of this, they need to be informed.

@PlaksoBirgit
Copy link
Collaborator

@DanBondarenko thanks for pointing that out!
In Wiki details are described but @KaarelKa can comment if that part has been clear or perhaps gone unnoticed due to not being in design?

@KaarelKa
Copy link

KaarelKa commented Aug 22, 2023

This part is added on FE, currently we just show it all the time, but I have a comment in code and a variable for checking it. Currently just not 100% sure what field to check. Assuming it will be "meta.display_start_time" field of the chosen "type_classifier_value". Will add the check, once we get "PROJECT_TYPE" classifiers from BE and I can recheck if it will be this field

@DanBondarenko
Copy link

This part is added on FE, currently we just show it all the time, but I have a comment in code and a variable for checking it. Currently just not 100% sure what field to check. Assuming it will be "meta.display_start_time" field of the chosen "type_classifier_value". Will add the check, once we get "PROJECT_TYPE" classifiers from BE and I can recheck if it will be this field

@KaarelKa After discussing this with Markus and Dima, we found that the boolean deciding this will be stored in the PROJECT_TYPE_CONFIGS table. This table holds an UUID reference to a PROJECT_TYPE classifier value (it’s not the most straightforward structure, but it’s what we have). I’ll create a corresponding endpoint (e.g. project-type-configs) in translation order service, so FE can receive the configurations.

@KaarelKa KaarelKa moved this from Ready for Build to Ready for Testing in Tõlkevärav (Translation Hub) Sep 14, 2023
@MariusJulius
Copy link
Collaborator Author

MariusJulius commented Oct 26, 2023

@VaabelMaret

@MariusJulius MariusJulius assigned VaabelMaret and unassigned KaarelKa Oct 26, 2023
@MariusJulius MariusJulius moved this from Ready for Testing to Todo in Tõlkevärav (Translation Hub) Oct 26, 2023
@VaabelMaret VaabelMaret moved this from Todo to In Progress in Tõlkevärav (Translation Hub) Nov 6, 2023
@VaabelMaret VaabelMaret moved this from In Progress to In Review in Tõlkevärav (Translation Hub) Nov 6, 2023
@VaabelMaret VaabelMaret moved this from In Review to Ready for Testing in Tõlkevärav (Translation Hub) Nov 16, 2023
@plakitkelly
Copy link

It's not possible yet to create new order with start time

Image

@MariusJulius MariusJulius moved this from Ready for Testing to Todo in Tõlkevärav (Translation Hub) Nov 27, 2023
@MariusJulius
Copy link
Collaborator Author

Needs BE review and implementations.

@MariusJulius
Copy link
Collaborator Author

BE side was fixed, it should work now.

@MariusJulius MariusJulius moved this from Blocked to Ready for Testing in Tõlkevärav (Translation Hub) Dec 5, 2023
@plakitkelly
Copy link

It's OK

@plakitkelly plakitkelly moved this from Ready for Testing to Done in Tõlkevärav (Translation Hub) Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants