Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Added favicon and a title for a more professional look #136

Merged
merged 2 commits into from
May 31, 2024

Conversation

Shoetan
Copy link
Contributor

@Shoetan Shoetan commented May 30, 2024

Closes: #88

Summary of Changes

  1. Downloaded the logo from the resource folder

    • Located the logo file in the project's resource folder.
  2. Created an .ico file from the image

    • Converted the logo image to an .ico file format for compatibility.
  3. Replaced the favicon in manifest.json with the newly created .ico image

    • Updated the manifest.json to use the new .ico file as the favicon.
  4. Installed react-helmet package to manage changes to the document head

    • Added react-helmet to the project to facilitate easy management of the document head, like the page title and subsequent seo tactics.
      Screenshot 2024-05-30 at 18 35 32

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
joyboy ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 9:52am
joyboy-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 9:52am

Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important title tag is the one at the index.html file. It should be changed, not the App.tsx.
Can you please remove the changes in the App.tsx, and do those changes at the index.html file?

Also there are various tools to generate favicon, social image, apple touch icon etc. can you use one of those tools to generate the favicon?
My recommendation would be to use favicon.io

@Shoetan
Copy link
Contributor Author

Shoetan commented May 31, 2024

Thank you @ugur-eren for your comments I will implement the changes requested. For the favicon I actually did use favicon.io to generate it .

Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@ugur-eren ugur-eren merged commit 6b21308 into keep-starknet-strange:main May 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FavIcon and Page title
2 participants