Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Show progress of docker pull #30

Open
apoorvsadana opened this issue Aug 21, 2023 · 0 comments
Open

Feat: Show progress of docker pull #30

apoorvsadana opened this issue Aug 21, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@apoorvsadana
Copy link
Collaborator

docker.modem.followProgress has an onProgress event listener. We can use that to detect the progress of the Docker installation and show it to the user. Currently, we just show a simple infinite loader.

The progress event fired by Dockerode isn't a simple event with progress percentage, instead it contains the actual logs you see during docker pull. So we need to come up with a neat way to show the progress to the user. Some ideas

  • Calculate the total progress % using some formula
  • Show a dialog box which shows the logs as it is from the user
@apoorvsadana apoorvsadana added enhancement New feature or request good first issue Good for newcomers labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant