bug: Cairo 2.6.0 contracts fail to compile

[SamrendraS]

Bug Report

On declaring contracts compiled with Cairo 2.6.0, Madara returns a 500 error

2024-04-30 12:44:13 Failed to convert BroadcastedTransaction to AccountTransaction: Failed to compile to Sierra

The same issue can be resolved when compiling with Cairo 2.5.0.

Steps to reproduce:
casm.contract_class.json
sierra.compiled_contract_class.json

The files linked above are ones generated with Cairo 2.6.0, attempting to declare them causes an error in Madara

[tdelabro]

@m-kus we talked about this at some point no?

@SamrendraS, to me, this seems like the intended behavior.

This version of Madara, only supports declaring contracts compiled with one specific version of the compiler.
If we upgrade Madara to a later version of cairo, we will stop supporting the previous one.
We want to be able to execute already declared classes that have been compiled with past versions of the compiler, but to only accept new ones that have been compiled with the latest version.

@EvolveArt @apoorvsadana @antiyro any opinion?

[m-kus]

Sorry, missed the mention 🙈

@tdelabro yes exactly, had the same issue, mentioned here https://github.com/keep-starknet-strange/madara/blob/main/crates/client/starknet-block-import/README.md#notes

IIRC one of the proposed solutions was to have multiple external compilers for the according version ranges.