Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash while downloading favicon #7103

Closed
ADD-SP opened this issue Nov 2, 2021 · 1 comment · Fixed by #7104
Closed

Crash while downloading favicon #7103

ADD-SP opened this issue Nov 2, 2021 · 1 comment · Fixed by #7104
Labels
bug

Comments

@ADD-SP
Copy link
Contributor

ADD-SP commented Nov 2, 2021 •
edited
Loading

Overview

Clicking Cancel while downloading favicons may crash

PR #7104

Steps to Reproduce

  1. Unlock database.
  2. Select a group
  3. Click Groups -> Download All Favicons.
  4. Click Cancel or Close immediately.

Expected Behavior

No crash.

Actual Behavior

The more favicons that need to be downloaded, the higher the probability of crashing. I need to download at least 20 favicons and it crashes every time.

Context

KeePassXC - Version 2.6.6
Revision: 9c108b9

Qt 5.15.2
Debugging mode is disabled.

Operating system: Windows 10 Version 2009
CPU architecture: x86_64
Kernel: winnt 10.0.19043

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey

Cryptographic libraries:

  • libgcrypt 1.9.2-unknown

Operating System: Windows10 x64
@ADD-SP ADD-SP added the bug label Nov 2, 2021
@ADD-SP ADD-SP mentioned this issue Nov 2, 2021
Merged
@ADD-SP
Copy link
Contributor Author

ADD-SP commented Nov 5, 2021 •
edited
Loading

I recorded the reproduction steps, please see this image below.

0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash while downloading favicon
1 participant
@ADD-SP