Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements for "New key association request" #838

Closed
jsha opened this issue Aug 1, 2017 · 6 comments
Closed

UX improvements for "New key association request" #838

jsha opened this issue Aug 1, 2017 · 6 comments

Comments

@jsha
Copy link

jsha commented Aug 1, 2017

When you install chromeIPass (or Passifox, but I haven't tested), and hit "Connect," you get this dialog box:

screenshot from 2017-07-31 17-44-11

Issues:

  • The title extends beyond the space available and is cut off
  • The help icon ("?") doesn't work (for me, on Windows 11, KeePassXC 2.2.0)
  • The text says "for the above key," but there is no key described above.
  • The text should describe what an association request is for, and why the user should choose a name. It could even suggest a default name, like "browser", or "chrome" (possibly based on User-Agent?)
@duk3luk3
Copy link

duk3luk3 commented Aug 6, 2017

  • It should allow to choose which database(s) to add the key to

duk3luk3 added a commit to duk3luk3/keepassxc that referenced this issue Aug 6, 2017
* !WIP!
* Creates a new dialog widget for accepting keys - needed for keepassxreboot#838

For keepassxreboot#838, keepassxreboot#530
duk3luk3 added a commit to duk3luk3/keepassxc that referenced this issue Sep 21, 2017
* !WIP!
* Creates a new dialog widget for accepting keys - needed for keepassxreboot#838

For keepassxreboot#838, keepassxreboot#530
duk3luk3 added a commit to duk3luk3/keepassxc that referenced this issue Dec 12, 2017
* !WIP!
* Creates a new dialog widget for accepting keys - needed for keepassxreboot#838

For keepassxreboot#838, keepassxreboot#530
@LinuxOnTheDesktop
Copy link

The text should describe what an association request is for, and why the user should choose a name.

I agree with this. However: does my version of KeePassXC (2.3.4) already include any changes made as a result of this ticket? For I still find the window - shown below - unclear.

image

The text in the window does not really make it clear what is being done or indeed what the user is being asked to name.

Thanks.

@droidmonkey droidmonkey added this to the v2.4.1 milestone Feb 4, 2019
@droidmonkey
Copy link
Member

droidmonkey commented Feb 4, 2019

Since this issue is still open that means we have not merged any changes into a branch for this issue. I am marking it for 2.4.1.

@LinuxOnTheDesktop
Copy link

@droidmonkey

Ah yes, that makes sense. Thank you for explaining. I am glad an improvement is in the works.

@outdooracorn
Copy link
Contributor

outdooracorn commented Mar 18, 2019

I agree with this issue, adding my two cents about @jsha's last bullet point:

It isn't clear to me if this is a name for the DB to be stored in the extension OR a name for the extension to be stored in the DB.

The title of the popup started with KeePassXC: which lead me to believe it was a name for the extension to be stored in the DB. However, under KeePassXC-Browser -> Settings -> Connected Databases it says The following KeePassXC databases are connected to KeePassXC-Browser. with the name I entered previously listed as the identifier. This leads me to believe it is a name for the DB in the extension. 😕 Which is it?

@droidmonkey
Copy link
Member

For now, don't think too hard about it and give it a nice name like "laptop-chrome" and move on with what you were doing. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants