Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prevent encoding utf-8 chars in README #88

Merged
merged 3 commits into from
Jul 5, 2019

Conversation

zizizi17
Copy link
Contributor

@zizizi17 zizizi17 commented Jul 4, 2019

#87

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #88   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         187    187           
  Branches       21     21           
=====================================
  Hits          187    187
Impacted Files Coverage Δ
src/readme.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0877ce0...9ae520a. Read the comment docs.

@kefranabg
Copy link
Owner

Hi @zizizi17,

Thanks for this PR 🙏

I'll do a review ASAP 👍

@kefranabg kefranabg changed the title Prevent encoding utf-8 chars in README ✨ Prevent encoding utf-8 chars in README Jul 5, 2019
@kefranabg kefranabg changed the title ✨ Prevent encoding utf-8 chars in README 🐛 Prevent encoding utf-8 chars in README Jul 5, 2019
@kefranabg
Copy link
Owner

Hey !

I just added a test to check this case, and also added in you as a contributor.

Thanks for your work ! 💪

@kefranabg kefranabg merged commit 8059756 into kefranabg:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants