Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GraphicsMagick #7

Closed
cblock opened this issue Oct 29, 2017 · 3 comments
Closed

Support for GraphicsMagick #7

cblock opened this issue Oct 29, 2017 · 3 comments
Assignees

Comments

@cblock
Copy link
Contributor

cblock commented Oct 29, 2017

Hi!

Over at http://www.github.com/cblock/exfile-graphicsmagick I created a clone of this repo that runs GraphicsMagick instead of ImageMagick. Initially I thought this could be added to the exfile description as an alternative to exfile-imagemagick. But essentially the only thing I did was to replace system calls to convert with GM convert etc.

So now I think it's not worth the duplication of code and I propose to add a config switch to this repo that lets users choose which library to use. What do you think?

@keichan34
Copy link
Owner

keichan34 commented Oct 30, 2017

I don't see a problem with that. Would you prefer an explicit configuration option, or should the library detect if GM is available and automatically use that, falling back on ImageMagick?

@cblock
Copy link
Contributor Author

cblock commented Oct 30, 2017

I'd prefer an explicit config option with imagemagick being the default config. That way one can explicitly control which library to use.

@keichan34
Copy link
Owner

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants