Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor!: migrate to esm and update dependencies (#256)" #259

Merged
merged 1 commit into from
May 1, 2022

Conversation

MichaelDeBoey
Copy link
Contributor

This reverts commit 3e4ff74.

#256 should have ben a breaking/major release.

CC/ @fisker @keithamus

Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite right. This one slipped through. Thanks!

@keithamus keithamus merged commit 80648cd into keithamus:master May 1, 2022
@github-actions
Copy link

github-actions bot commented May 1, 2022

🎉 This PR is included in version 1.56.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey deleted the revert-esm branch May 1, 2022 18:03
@ph-fritsche
Copy link

ph-fritsche commented May 2, 2022

I just happened to have this contribution in my feed. Have a look at ph-fritsche/action-release.
It's a GitHub Action wrapper for semantic-release and it defaults to Conventional Commits, i.e. refactor!: triggers a major release.

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented May 2, 2022

@ph-fritsche What's the main difference with cycjimmy/semantic-release-action?

@ph-fritsche
Copy link

First of all it's written in Typescript, is unit-tested and dogfeeds itself. I initially wanted to write a PR for cycjimmy's code, but wasn't confident to implement new features without tests or types so I started from scratch.

  • There is a default config that sets the preset to conventionalcommits, adds main to the release branches and omits the npm and github plugin if you omit the respective token.

  • It installs the appropriate conventional-changelog package and any plugins you list in an inline or shared config.

  • It adds and updates moving tags, i.e. for a v1.2.3 it also moves v1.2 and - if there isn't already a v1.3 - v1 to that commit, or for a v1.2.3-alpha.4 it moves the v1.2.3-alpha tag.

@fisker
Copy link
Collaborator

fisker commented Jun 5, 2022

Should we revert it back? The original PR is fine, only because the release bot not work as expected, we should revert this one and make sure we release v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants