-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "refactor!: migrate to esm and update dependencies (#256)" #259
Conversation
)" This reverts commit 3e4ff74.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite right. This one slipped through. Thanks!
🎉 This PR is included in version 1.56.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I just happened to have this contribution in my feed. Have a look at ph-fritsche/action-release. |
@ph-fritsche What's the main difference with |
First of all it's written in Typescript, is unit-tested and dogfeeds itself. I initially wanted to write a PR for cycjimmy's code, but wasn't confident to implement new features without tests or types so I started from scratch.
|
Should we revert it back? The original PR is fine, only because the release bot not work as expected, we should revert this one and make sure we release v2. |
This reverts commit 3e4ff74.
#256 should have ben a breaking/major release.
CC/ @fisker @keithamus