Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: migrate to esm and update dependencies #256

Merged
merged 7 commits into from
Apr 4, 2022
Merged

refactor!: migrate to esm and update dependencies #256

merged 7 commits into from
Apr 4, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Apr 4, 2022 •
edited
Loading

Fixes #254
Fixes #247
Fixes #227
Closes #255

[BREAKING]: Require Node.js 12

@fisker fisker marked this pull request as ready for review April 4, 2022 10:34
keithamus
keithamus previously approved these changes Apr 4, 2022
View reviewed changes
Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge will semantic release cut a release? Should we batch this with the other breaking changes?

@fisker
Copy link
Collaborator Author

fisker commented Apr 4, 2022

I don't know. Let me update other deps in this one then.

@fisker
Copy link
Collaborator Author

fisker commented Apr 4, 2022

I think we need to update index.d.ts? I'm not familiar with types, can you fix it?

@fisker fisker changed the title refactor!: migrate to esm refactor!: migrate to esm and update dependencies Apr 4, 2022
keithamus
keithamus previously approved these changes Apr 4, 2022
View reviewed changes
@keithamus keithamus merged commit 3e4ff74 into keithamus:master Apr 4, 2022
@keithamus
Copy link
Owner

Looks like the refactor didn't trigger a release, but I imagine the next one will be breaking.

@fisker fisker deleted the esm branch April 4, 2022 15:33
@fisker
Copy link
Collaborator Author

fisker commented Apr 4, 2022

Looks like the breaking change should trgger by the commit message footer https://semantic-release.gitbook.io/semantic-release/#how-does-it-work

@github-actions
Copy link

github-actions bot commented May 1, 2022

🎉 This PR is included in version 1.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thisislawatts thisislawatts mentioned this pull request May 1, 2022
Closed
@pSnehanshu
Copy link

This should have been a major version bump.

@mdjermanovic mdjermanovic mentioned this pull request May 1, 2022
Closed
1 task
MichaelDeBoey added a commit to MichaelDeBoey/sort-package-json that referenced this pull request May 1, 2022
@MichaelDeBoey
Revert "refactor!: migrate to esm and update dependencies (keithamus#256
0549cc1 
)"

This reverts commit 3e4ff74.
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 1, 2022
Merged
@MichaelDeBoey
Copy link
Contributor

@fisker @keithamus This should have been in a breaking/major release.

I created #259 to revert this PR.
We could add it again & make sure it's a breaking/major release afterwards, but this is making sure the package isn't breaking dependents anymore.

keithamus pushed a commit that referenced this pull request May 1, 2022
@MichaelDeBoey
Revert "refactor!: migrate to esm and update dependencies (#256)" (#259)
80648cd
fisker added a commit that referenced this pull request Sep 28, 2022
@fisker
Revert "Revert "refactor!: migrate to esm and update dependencies (#256…
2af2c89 
…)" (#259)"

This reverts commit 80648cd.
@fisker fisker mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to ES Module? Please update globby@10.0.0 to at least 11.0.0 globby v12
4 participants
@fisker @keithamus @pSnehanshu @MichaelDeBoey