-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UUID v3 Support #217
Merged
Merged
UUID v3 Support #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks good, thanks! (It'll be nice to finally round out all the uuid versions in this module after all these years. :-D ) One change: v3.js and v5.js are identical but for a couple lines. Let's factor that code into a common module (e.g. v35.js:
v3.js
v5.js
|
Good idea. Updates made. |
broofa
approved these changes
Sep 7, 2017
broofa
added a commit
that referenced
this pull request
Jan 16, 2018
Note: Actual change is in dc02a76. Just making a placeholder commit here so the note gets picked up by standard-version and put in the CHANGELOG.md file.
broofa
added a commit
that referenced
this pull request
Jan 16, 2018
* +package-lock.json because npm requires it * 3.2.0 * README updates * fix: remove mistakenly added typescript dependency, rollback version (standard-version will auto-increment) * chore: fixup README, update package-lock * feat: Add v3 Support (#217) Note: Actual change is in dc02a76. Just making a placeholder commit here so the note gets picked up by standard-version and put in the CHANGELOG.md file. * chore(release): 3.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for UUID v3 based on the code for v5. Since v3 and v5 are generated in almost exactly the same way the major addition to this is added
md5
(using crypto) andmd5-browser
(based on the implementation in https://github.com/blueimp/JavaScript-MD5) to thelib
directory and then using them.Updated tests, CLI commands, README_js.md, and tests. I needed v3 support for older systems as we migrate them to JavaScript.
Happy to make any additional changes.