Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing partial history search functionality #82

Closed
kylo252 opened this issue May 22, 2021 · 1 comment · Fixed by #83
Closed

Missing partial history search functionality #82

kylo252 opened this issue May 22, 2021 · 1 comment · Fixed by #83

Comments

@kylo252
Copy link

kylo252 commented May 22, 2021

When using zsh you can invoke the history widget and it will use what you already have as input to match commands from history. While PSFzf doesn't care about what you already have written before invoking it ctrl+r.

A second point is that it doesn't replace the entire line but rather insert it at the cursor position. I suspect because you had always planned for this to be used on an empty line.

See an example here:
lzFJZh4O5l

I tried to take a look at the code but sadly my experience with PowerShell scripting is very limited. I suspect you can probably re-use some of the logic in PSFzf.TabExpansion.ps1 specifically the part where you use GetBufferState().

P.S. thanks for the amazing work!

@kelleyma49
Copy link
Owner

Good points. I will look at this when I have some free time. It shouldn't be too hard to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants