Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules listening for bot events can still trigger even when not toggled on #13

Closed
seiyria opened this issue Dec 14, 2013 · 3 comments
Closed

Comments

@seiyria
Copy link
Member

seiyria commented Dec 14, 2013

No description provided.

@rahatarmanahmed
Copy link
Contributor

I thought we wanted this?

@seiyria
Copy link
Member Author

seiyria commented Dec 15, 2013

I'm not sure how I feel about it. The idea of toggling a module should be
predictable, ie, you should toggle a module and all functionality should be
disabled. However, I'm not certain how easy it is to implement this, as I
did not do anything with the base bot events.

@seiyria
Copy link
Member Author

seiyria commented Jan 3, 2014

I've decided that the module implementer needs to decide if they should respect this or not. There are cases where it is applicable and there are cases where it is not.

@seiyria seiyria closed this as completed Jan 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants