Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shouldComponentUpdate-ish feature #14

Open
filipbech opened this issue Nov 1, 2017 · 2 comments
Open

Add shouldComponentUpdate-ish feature #14

filipbech opened this issue Nov 1, 2017 · 2 comments

Comments

@filipbech
Copy link
Contributor

this will make things faster and we can make immutable data a native citizen

@kenchris kenchris changed the title [feature] add shouldComponentUpdate-ish feature Add shouldComponentUpdate-ish feature Nov 13, 2017
@kenchris
Copy link
Owner

kenchris commented Jan 9, 2018

This is not needed if my PR gets merged in lit-html lit/lit#239

@filipbech
Copy link
Contributor Author

Im not sure that eliminates the need completely... it does cover the most important part though...

What if a property change causes something async to happen (a fetch or similar) that then needs to invalidate... being able to opt out of re-rendering could still be a nice feature...

or what I know my data is always immutable - I can skip the object equality check altogether...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants