-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #3
Comments
My thoughts on what tests to start out with... The different allowed property-types - should keep their types when changed from prop or via attr
(note to self) webcomponents-tester guide here: https://www.polymer-project.org/1.0/docs/tools/tests |
Hi, sorry if this is spammy, and feel welcome to delete my comment if it takes up too much space. FrameElement Listeners Maybe they can serve as inspiration when you get around to it :) |
There are a few optimizations that can be done, like I believe there is an invalidate call too much and a call to typeFn too much. But tests would make sure that we don't break anything when making such changes.
Also use web components polyfill to test on Firefox
The text was updated successfully, but these errors were encountered: