Taking redis client from django.core.cache

[Franr]

The idea is to avoid rewriting the Redis URL on the defender settings, since probably you already have it on your django CACHES settings.

Pending:

• tests
• documentation

[kencochrane]

django 1.6 is no longer supported, support ended on April 1, 2015 https://www.djangoproject.com/download/#supported-versions did you mean another version?

[kencochrane]

we talked about this in the issue #81 instead of adding the and to the elif, maybe we do a check above, and then display an error message and fail if the DEFENDER_REDIS_NAME is set but not available in caches. This way we still fail right away, and we give it a nice error message to let them know what is going on vs just a generic KeyError.

[coveralls]

Coverage decreased (-0.4%) to 95.437% when pulling aa40dea on Franr:redis-from-cache into a59cbca on kencochrane:master.

[Franr]

Well no, but travis-ci is still running tests over it, so I thought you still wanted to support it. Also it is still on the doc https://github.com/kencochrane/django-defender#requirements 😛

[kencochrane]

ha, yeah we should probably clean that up and remove support below django 1.8.

[coveralls]

Coverage decreased (-0.4%) to 95.437% when pulling 32c20d7 on Franr:redis-from-cache into a59cbca on kencochrane:master.

[Franr]

Good. @kencochrane removed support for both versions 👍

[coveralls]

Coverage decreased (-0.4%) to 95.437% when pulling 5cef219 on Franr:redis-from-cache into a59cbca on kencochrane:master.

[kencochrane]

thank you

[coveralls]

Coverage decreased (-0.4%) to 95.437% when pulling 5cef219 on Franr:redis-from-cache into a59cbca on kencochrane:master.

[coveralls]

Coverage decreased (-0.3%) to 95.49% when pulling 2727f63 on Franr:redis-from-cache into a59cbca on kencochrane:master.

[coveralls]

Coverage increased (+0.03%) to 95.85% when pulling ec6c3f1 on Franr:redis-from-cache into a59cbca on kencochrane:master.

[coveralls]

Coverage increased (+0.03%) to 95.85% when pulling 9244de1 on Franr:redis-from-cache into a59cbca on kencochrane:master.

[coveralls]

Coverage increased (+0.03%) to 95.85% when pulling d569a33 on Franr:redis-from-cache into a59cbca on kencochrane:master.

[MattBlack85]

one note here, since we are dropping support for django < 1.8 we should remove python 2.6 as well from the test matrix since from django 1.8 only python 2.7 is supported

https://docs.djangoproject.com/en/1.11/faq/install/#what-python-version-can-i-use-with-django

[kencochrane]

@MattBlack85 Good catch, let's do that as well

[coveralls]

Coverage increased (+0.03%) to 95.85% when pulling b05d74b on Franr:redis-from-cache into a59cbca on kencochrane:master.

[Franr]

@kencochrane @MattBlack85 done, and added a little doc about the new setting. Who should I ask for a review?

[kencochrane]

Looks good to me. Thank you!